Bug Fix : JS error on IE9 #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
added
T2
|
+1 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer the following questions:
Description
When using the javascript with IE9, there is a javascript error generated (seems to be at MauticJS.documentReady, it expects a function and not a string...)
Steps to reproduce the bug (if applicable)
Just open a page with the script included on IE9, and watch errors on console. You can also emulate IE9 with IE Developer Tools
Steps to test this PR
Just reproduce with this PR
Solution
There was a mistake, as MautiJS.documentReady must have a function as parameter, and not a string. New browser are able to convert string to function, but not older one...