Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the froala's form.submit event is triggered before froala's style cleared #2010

Merged
merged 1 commit into from Jul 11, 2016

Conversation

escopecz
Copy link
Sponsor Member

Please answer the following questions:

Q A
Bug fix? Y
New feature? N
BC breaks? N
Deprecations? N
Fixed issues /

Description

With the 2.0.1 PR's merged together, there is again an issue with table border styles which are added by Froala.

Steps to reproduce the bug (if applicable)

Save a table-based page or email and preview it. You should see the borders around all tables.

Steps to test this PR

Apply this PR, refresh your browser (in dev mode) or build prod assets (in production mode) and save the email/page again. The borders should disappear.

@escopecz escopecz added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jul 11, 2016
@escopecz escopecz added this to the 2.0.1 milestone Jul 11, 2016
@dongilbert
Copy link
Member

+1

@dongilbert dongilbert merged commit ff53b8d into mautic:staging Jul 11, 2016
@mqueme
Copy link
Contributor

mqueme commented Jul 11, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants