Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Company based marketing #2558

Merged
merged 123 commits into from Sep 29, 2016
Merged

Company based marketing #2558

merged 123 commits into from Sep 29, 2016

Conversation

mqueme
Copy link
Contributor

@mqueme mqueme commented Sep 19, 2016 •
edited

Q A
Bug fix? n
New feature? y
Related user documentation PR URL mautic/documentation#99
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR creates a new company so contacts can now belong to a company, and allows segments to be filtered by company.

Steps to test this PR:

  1. Apply this PR run migrations
  2. test that the new company menu is there and that everything works
  3. on the list of contacts you can now batch assign leads to a company.
  4. on a contact's detail view you can now see the companies it belongs to.
  5. on a contact's detail view you can add or remove a company
  6. on the company's list view you can see the number of leads in each company
  7. on the list of contacts you can now filter by company_name:nameOfCompany
  8. create some companies, add contacts to a company, then create a segment with filters that 9. would apply to your values.
  9. you should now have contacts in your segment that meet both contact filters and company filters criteria.
  10. create a new campaign and select action to add a new company, test campaign
  11. try to submit a form with all required fields to identify a company, and find the lead being assigned to that company.

Steps to reproduce the bug:

List deprecations along with the new alternative:

List backwards compatibility breaks:

@mqueme
created company based marketing
8dbcbda
@mqueme
changed account to company
1e050ff
@mqueme
added new company bundle
d030d1b
@mqueme
Merge branch 'staging' of https://github.com/mautic/mautic into compa…
d80258f 
…ny-bundle
@mqueme
batch add/remove contacts from companies, view number of contacts in …
8cba453 
…a company, filter

contacts per company, add/remove companies from contacts profile, view companies in contact's profile
@mqueme
moved comapany to lead bundle, changed company to use custom fields, …
6912a0e 
…modified company views

 Please enter the commit message for your changes. Lines starting
@mqueme
changes needed to be able to use custom fields for company
087d84f
@mqueme
batch add/remove contacts from companies, view number of contacts in …
feb10b5 
…a company, filter

contacts per company, add/remove companies from contacts profile, view companies in contact's profile
@mqueme
adapted for new changes in company-bundle
332df64
@mqueme
made changes for new company custom fields
bd33c23
@mqueme
addapted for new company custom fields
979ff12
@mqueme
Merge branch 'company-leads' of https://github.com/mqueme/mautic into…
19367f8 
… company-leads
@mqueme
removed duplicated lines
206fc19
@mqueme
fixed saveentity to work with custom fields
18ba724
@mqueme
adding company fields to segment filters
15dd5a4
@mqueme
added support for company filters in segments
79a2500
@mqueme
fixed bugs around a filed being removed by mistake
b30a58c
@mqueme
fixed assigning contact to company from the company profile (this wil…
e10d114 
…l change anyway)
@mqueme
fixed issues around saving the company details
356386e
@mqueme
Merge branch 'company-bundle' of https://github.com/mqueme/mautic int…
7a75543 
…o company-leads
@mqueme
fixed some error when displaying company name on the contac's profile
708dd71
@mqueme
added campaing add to company action
bc47626
@mqueme
Merge branch 'company-bundle' of https://github.com/mqueme/mautic int…
559a584 
…o company-campaign-action
@mqueme
Merge branch 'company-leads' of https://github.com/mqueme/mautic into…
bc77623 
… company-segments
@mqueme
removed the remanence of the company bundle which was moved to leadbu…
1db2863 
…ndle
@mqueme
Merge branch 'company-campaign-action' of https://github.com/mqueme/m…
230d264 
…autic into company-leads
@mqueme
fixed install bundle to include company core fields
d5bc652
@mqueme
fixed install bundle to install company core fields and indexes
3b69c6c
@mqueme
Merge branch 'company-bundle' of https://github.com/mqueme/mautic int…
fb82dfb 
…o company-leads
@mqueme
Merge branch 'company-bundle' of https://github.com/mqueme/mautic int…
883273e 
…o company-algorithm
alanhartless and others added 28 commits September 29, 2016 00:04
@alanhartless
Prevented doctrine from deleted company custom fields and corrected h…
0477dbe 
…andling of indexes
@alanhartless
Fixed not being able to remove all companies from a contact
bdc9610
@alanhartless
Fixed issue where Company::getName() did not return the name. Also ke…
17017b0 
…pt lead custom field company and update it with the primary company. This keeps BC for API results and for Lead::getPrimaryIdentifier
@alanhartless
Clear company name when all companies are removed
86ce669
@alanhartless
Made company columns sortable and removed some MauticFactory uses
bdd496b
@alanhartless
Fixed company pagination
9d1d954
@alanhartless
Fixed the change log to include company id and corrected missing sche…
5699569 
…ma from metadata
@alanhartless
Fixed API and form submissions to correctly map company and/or create…
8c12c82 
… a new one if it does not exist
@mqueme
assigning object to lead_fields on install
7181cf5
@mqueme
Merge branch 'company-based-marketing' of https://github.com/mqueme/m…
cd5736c 
…autic into company-based-marketing
@mqueme
Fix: added missing schema execution
6f28d9d
@mqueme
Fix: On field data installation ORM was getting confused, changed it …
23c1638 
…so that it would create fields in the right table. also added missing translations, changed the other tab to professional tab in the company view
@mqueme
added company fields translations to fixtures
851b241
@mqueme
removed company text field from contact form, added missing translations
56cc968
@mqueme
fixed: new company not returning to list view
fa409e0
@alanhartless
Fixed corrupt serialized migration string
24b5032
@mqueme
changed industry field to select in migration file
e3d3a1f
@mqueme
Merge branch 'staging' of https://github.com/mautic/mautic into compa…
72b8f8d 
…ny-based-marketing
@mqueme
Merge branch 'company-based-marketing' of https://github.com/mqueme/m…
cf5a868 
…autic into company-based-marketing
@alanhartless
Fetch company profile fields for email listeners
62a1554
@alanhartless
Fixed bad serialized array
6f137d9
@alanhartless
more support for fetching company profile data
27cd07d
@dongilbert
Fix field lookups on company fields
879fa1d
@alanhartless
Fixed some lost field changes with the merge
ed3d361
@alanhartless
Merge branch 'company-based-marketing' of github.com:mqueme/mautic in…
70ff44d 
…to marianela-company-based-marketing

# Conflicts:
#	app/bundles/LeadBundle/Model/CompanyModel.php
@dongilbert
Fix company model key for getModel
a38e3b5
@alanhartless
Merge branch 'staging' into marianela-company-based-marketing
613232b 
# Conflicts:
#	media/js/app.js
@alanhartless
Merge branch 'company-based-marketing' of github.com:mqueme/mautic in…
32a3e86 
…to marianela-company-based-marketing
@alanhartless alanhartless merged commit f4d0108 into mautic:staging Sep 29, 2016
@LevryKurniawan LevryKurniawan mentioned this pull request Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz left review comments

@dongilbert dongilbert dongilbert approved these changes

Assignees
No one assigned
Labels
pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mqueme @dongilbert @escopecz @alanhartless