Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin was not fetching the correct fields per object #2613

Merged
merged 7 commits into from
Oct 12, 2016

Conversation

mqueme
Copy link
Contributor

@mqueme mqueme commented Sep 30, 2016

Q A
Bug fix? y
New feature? n
Related user documentation PR URL na
Related developer documentation PR URL na
Issues addressed (#s or URLs) na
BC breaks? na
Deprecations? na

Description:

Steps to test this PR:

  1. Apply this PR, run the fetch command for Salesforce
  2. Match your fields - specifically boolean fields
  3. Bug should not be displayed

Steps to reproduce the bug:

  1. Enable your salesforce plugin
  2. Select to match leads and contacts
  3. run the fetch command

php app/console mautic:integration:fetchleads --integration=Salesforce --time-interval="29 days" -e=dev
on dev mode for testing purposes.

-An error is displayed when trying to fetch info from the contacts object.

@alanhartless alanhartless added this to the 2.2.1 milestone Sep 30, 2016
@mqueme mqueme added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test Hacktoberfest T3 Hard difficulty to fix (issue) or test (PR) labels Oct 7, 2016
Copy link
Contributor

@alanhartless alanhartless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make booleans not be required so I didn't have to map Salesforce's "Unread By Owner" field. But syncing properly mapped the boolean!

@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
@escopecz
Copy link
Sponsor Member

I had some troubles to configure the whole thing, but when that was done, it works 👍

@alanhartless alanhartless merged commit 728993e into mautic:staging Oct 12, 2016
@isleshocky77
Copy link
Contributor

@mqueme Thank you for this. I was just coming to put in the same issue as I've manually made the changes locally and was looking to see if I should make a pull request.

I've tested the staging branch and it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test T3 Hard difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants