Default values imported, boolean values can be true/false/yes/no

[escopecz]

Q	A
Bug fix?	Y
New feature?	Y
Related user documentation PR URL	mautic/documentation#115
Related developer documentation PR URL	/
Issues addressed (#s or URLs)	#1863, #2502
BC breaks?	N
Deprecations?	N

Description:

This PR does 2 things:

1. It imports also default values if the contact fields have any
2. It allows to import yes/no/true/false as Boolean values.

Steps to test this PR:

1. Apply this PR.
2. Test again.

Notice:

1. All 8 contacts were imported with correct Boolean values.
2. All contact have the default value in the Phone field.

Steps to reproduce the bug:

1. Make sure you have at least one contact field with default value. For example Phone field.
2. Create a new contact field called "Boolean Test" and is type of Boolean.
3. Try to import the following CSV:

"email", "stage", "company", "boolean_test"
"john2@doe.com", "test", "Google", "No"
"john1@doe.com", "test", "Google", 0
"john3@doe.com", "test", "Google", "false"
"john4@doe.com", "test", "Google", "FALSE"
"johana1@doana.com", "stage A", "Apple", 1
"johana2@doana.com", "stage A", "Apple", "Yes"
"johana3@doana.com", "stage A", "Apple", "true"
"johana4@doana.com", "stage A", "Apple", "TRUE"

Notice:

1. It will import only 2 out of 8 contacts. The reason is that text Boolean values are not valid.
2. The default Phone value wasn't imported to the contacts who got saved.

[alanhartless]

This could be simplified with $value = (int) filter_var($fieldData[$leadField['alias'], FILTER_VALIDATE_BOOLEAN);

http://php.net/manual/en/filter.filters.validate.php

Returns TRUE for "1", "true", "on" and "yes". Returns FALSE otherwise.

If FILTER_NULL_ON_FAILURE is set, FALSE is returned only for "0", "false", "off", "no", and "", and NULL is returned for all non-boolean values.

[escopecz]

Great suggestion. Implemented.

[mqueme]

0 contacts were created for me before and after merging this PR (#2)(My boolean field) This value is not valid.

[escopecz]

That's odd. I retested and all 8 contacts were imported. Could you double-check the PR was applied before test?

[alanhartless]

Worked for me with the given csv file. Boolean fields were imported correctly.

[dongilbert]

Works as described. Thanks for providing thorough test instructions. +1