Skip required validation when field is hidden by 'hide if exist' and has existing value. #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes form submit when required field gets hidden because of the ‘hide if value exist’ behaviour. Else form will halt and returns that x field is required, but this field is not shown on the frontend.
escopecz
added
T1
|
?? |
mqueme
added
pending-test-confirmation
escopecz
reviewed
Oct 11, 2016
| @@ -214,6 +214,12 @@ public function saveSubmission($post, $server, Form $form, Request $request = nu | |||
| } | |||
|
|
|||
| if ($f->isRequired() && empty($value)) { | |||
|
|
|||
| //field is required, but hidden from form because of 'ShowWhenValueExists' | |||
| if( null !== $f->getShowWhenValueExists() && $f->getShowWhenValueExists() === false ){ | |||
There was a problem hiding this comment.
Shouldn't this line be just:
if ($f->getShowWhenValueExists() === false ) {
because if something === false, the !== null part must be true as well, mustn't it?
|
Won't this skip validation for all fields set to show when value exists? Shouldn't we do a check on |
alanhartless
added
the
code-review-needed
…ow a field if the lead data is an empty string and not just null
alanhartless
removed
the
code-review-needed
|
I updated to only bypass validation if the field is not part of $post |
|
It seems to be working well 👍 |
alanhartless
approved these changes
Oct 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes form submit when previously a required field with the behaviour "Hide if value exist" was filled in. Now the form submits without return an error for the required field.
Steps to test this PR:
Steps to reproduce the bug: