Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export the first row as well as the header row #2628

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Export the first row as well as the header row #2628

merged 1 commit into from
Oct 11, 2016

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Oct 3, 2016

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) #2590
BC breaks? N
Deprecations? N

Description:

When exporting a CSV from reports, the first row you see in the report is replaced by the CSV header. This PR adds the header row as well as the first row.

Steps to test this PR:

  1. Apply this PR.
  2. Test again - the first row should be present.

Steps to reproduce the bug:

  1. Go to a report, make sure there are some rows in the report table.
  2. Export the report to CSV.
  3. Compare the CSV with the report table - the first row is missing.

@escopecz escopecz added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test Hacktoberfest labels Oct 3, 2016
@escopecz escopecz added this to the 2.2.1 milestone Oct 3, 2016
@mqueme
Copy link
Contributor

mqueme commented Oct 11, 2016

This works! should the heading be translated?

@escopecz
Copy link
Sponsor Member Author

What heading?

@mqueme mqueme added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Oct 11, 2016
@alanhartless alanhartless merged commit c653d97 into mautic:staging Oct 11, 2016
@escopecz escopecz mentioned this pull request Feb 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@escopecz @mqueme @alanhartless