Throw 404 instead of PHP error if email was not found #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
added
T1
|
like this?
|
|
@mqueme yes, this is how 404 page looks like in the dev env. |
|
then 👍 BTW the 500 error I got before was a different one from your example, but still a 500 error. |
mqueme
added
T2
mqueme
approved these changes
Oct 11, 2016
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The linked issue reported a PHP error that was caused by trying to access an email preview on email which did not exist. This PR adds a check if the email exists and throws 404 if not.
Steps to test this PR:
Steps to reproduce the bug:
Call to a member function isPublished() on nullin dev mode or it should be logged if using prod.