Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation string for mautic.campaign.twitter.tweet #2658

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

dongilbert
Copy link
Member

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? N/A
Deprecations? N/A

Description:

Adds a translation string for the mautic.campaign.twitter.tweet translation key.

Steps to test this PR:

  1. Apply the PR
  2. Repeat the steps to reproduce the bug. You'll see that the string is translated.

Steps to reproduce the bug:

  1. Create a campaign
  2. Add a "Tweet contact" action and save the campaign
  3. In the lower section of the campaign details on the "Actions" tab, you'll see a "Tweet contact" row. To the right on that row you'll see the string with a missing translation.

@dongilbert dongilbert added T1 Low difficulty to fix (issue) or test (PR) ready-to-test PR's that are ready to test Hacktoberfest labels Oct 6, 2016
@dongilbert dongilbert added this to the 2.2.1 milestone Oct 6, 2016
@mqueme
Copy link
Contributor

mqueme commented Oct 11, 2016

??

@mqueme mqueme added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Oct 11, 2016
@alanhartless alanhartless merged commit 9f74773 into mautic:staging Oct 11, 2016
@dongilbert dongilbert deleted the bugfix-tweet-message branch April 6, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-test-confirmation PR's that require one test before they can be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants