Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filtered lead matchup fields in forms, search company names with more… #2663

Merged
merged 3 commits into from
Oct 12, 2016

Conversation

mqueme
Copy link
Contributor

@mqueme mqueme commented Oct 7, 2016

Q A
Bug fix? y
New feature?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #2695 #2717
BC breaks?
Deprecations?

Description:

Company fields were being mixed up in the lead match fields for forms, when clicking on number of contacts on a company name that was made up of more than one word, filter did not work. Also fixed missing update_select missing option error that came up when clicking on Apply button in the company editing screen.

Steps to test this PR:

  1. Go to forms and insert a text field or any other field, try to match it to a lead field. Only lead fields should appear
  2. go to your list of companies find one that is more than two words and that it has contacts assigned, click on the link to view contacts, contacts assigned to that company should show on the list of contacts

Steps to reproduce the bug:

  1. In step one above company fields were appearing.
  2. in step two above, no contacts were showing for the company.

@mqueme mqueme added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test Hacktoberfest labels Oct 7, 2016
@mqueme mqueme added this to the 2.2.1 milestone Oct 7, 2016
Copy link
Contributor

@alanhartless alanhartless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just escaped the search string so that the "" showed up in the filter. But works otherwise +1

@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Oct 12, 2016
@dongilbert
Copy link
Member

Everything works as described. Thanks @mqueme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-feedback PR's and issues that are awaiting feedback from the author pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants