Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty theme form threw an error - fixed #2699

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Empty theme form threw an error - fixed #2699

merged 2 commits into from
Oct 11, 2016

Conversation

escopecz
Copy link
Sponsor Member

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? /
Deprecations? /

Description:

Submitting a theme upload form resulted in error instead of a validation message.

Steps to test this PR:

  1. Apply this PR.
  2. Repeat the test - should see a validation error message.

Steps to reproduce the bug:

  1. Go to the Theme manager
  2. Do not select any package and hit Submit - you should see a PHP error.

@escopecz escopecz added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 10, 2016
@escopecz escopecz added this to the 2.2.1 milestone Oct 10, 2016
@mqueme
Copy link
Contributor

mqueme commented Oct 11, 2016 •
edited by dbhurley
Loading

It's fixed. shows warning message correctly ??

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
@alanhartless alanhartless merged commit f99d7be into mautic:staging Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@escopecz @mqueme @alanhartless