Fixes ability to save Focus permissions #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhartless
added
bug
|
The error is gone and I'm able to save the Focus permissions with this PR applied 👍 |
escopecz
added
the
pending-test-confirmation
escopecz
added
ready-to-commit
|
Tested and works great. +1 Thanks @alanhartless! |
escopecz
removed
ready-to-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Saving a role that customizes focus permissions would result in an error.
Steps to test this PR:
Steps to reproduce the bug:
List deprecations along with the new alternative:
plugin:somePluginis no longer required due to permission class changes introduced in 2.2. This means that it's also no longer required to know track plugin vs core bundle. So, 2.2.1 deprecates this to be removed in 3.0.