Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed minute date format for exported form results #2709

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Fixed minute date format for exported form results #2709

merged 1 commit into from
Oct 12, 2016

Conversation

alanhartless
Copy link
Contributor

Q A
Bug fix? y
New feature? n
Related user documentation PR URL na
Related developer documentation PR URL na
Issues addressed (#s or URLs) #2553
BC breaks? n
Deprecations? n

Description:

The format used for exported form results was Y-m-d H:m:s which is wrong for minutes. This PR fixes it.

Steps to test this PR:

  1. Export form results as CSV or xls
  2. Note the date/time

Steps to reproduce the bug:

  1. Repeat the above and the minute will match the month

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 11, 2016
@alanhartless alanhartless added this to the 2.2.1 milestone Oct 11, 2016
@escopecz
Copy link
Sponsor Member

👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
virlatinus
virlatinus approved these changes Oct 12, 2016
View reviewed changes
Copy link
Contributor

@virlatinus virlatinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was ok!

@escopecz escopecz merged commit 09c33ad into mautic:staging Oct 12, 2016
@alanhartless alanhartless deleted the bug-2553 branch October 24, 2016 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virlatinus virlatinus virlatinus approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanhartless @escopecz @virlatinus