Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2480 #2710

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Bug 2480 #2710

merged 2 commits into from
Oct 11, 2016

Conversation

alanhartless
Copy link
Contributor

Q A
Bug fix? y
New feature? n
Related user documentation PR URL na
Related developer documentation PR URL na
Issues addressed (#s or URLs) #2480
BC breaks? n
Deprecations? n

Description:

This adds Host not found to DSN parsing for bounced emails.

Testing

Run Unit Test

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 11, 2016
@alanhartless alanhartless added this to the 2.2.1 milestone Oct 11, 2016
@escopecz
Copy link
Sponsor Member

OK (54 tests, 222 assertions) 👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
dongilbert
dongilbert approved these changes Oct 11, 2016
View reviewed changes
Copy link
Member

@dongilbert dongilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good, thanks @alanhartless!

@dongilbert dongilbert merged commit 2f67ce0 into mautic:staging Oct 11, 2016
@alanhartless alanhartless deleted the bug-2480 branch October 24, 2016 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alanhartless @escopecz @jkuchar @dongilbert