Fix for dropdowns in table-responsive using JS #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhartless
added
bug
|
The delete option is visible with this PR 👍 |
escopecz
added
the
pending-test-confirmation
|
?? |
mqueme
added
ready-to-commit
escopecz
reviewed
Oct 11, 2016
There was a problem hiding this comment.
The code removed in app.css will break email dynamic content. @dongilbert already committed a fix for this to https://github.com/mautic/mautic/pull/2653/commits, but that PR won't make it to 2.2.1. Don, could you apply that commit here as well?
dongilbert
approved these changes
Oct 11, 2016
There was a problem hiding this comment.
Thanks @alanhartless! To note, this PR also fixes dynamic content via "Insert Token"
escopecz
removed
ready-to-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The dropdowns on the last rows in table-responsive classes were cut off due to a "won't fix" Bootstrap issue. This uses JS to implement a fix by calculating and adding a padding.
Steps to test this PR:
Steps to reproduce the bug: