Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed SMS management quirks #2714

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Fixed SMS management quirks #2714

merged 1 commit into from
Oct 12, 2016

Conversation

alanhartless
Copy link
Contributor

@alanhartless alanhartless commented Oct 11, 2016 •
edited
Loading

Q A
Bug fix? y
New feature? n
Related user documentation PR URL na
Related developer documentation PR URL na
Issues addressed (#s or URLs) #2362 #2365 #1843
BC breaks? n
Deprecations? n

Description:

This fixes a few quirks with SMS management.

Steps to test this PR:

  1. Delete a SMS via individual and batch
  2. Create a new SMS and click close
  3. Clone a SMS

All should be successful.

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 11, 2016
@alanhartless alanhartless added this to the 2.2.1 milestone Oct 11, 2016
@alanhartless alanhartless changed the title Fixed clone and delete buttons Fixed SMS management quirks Oct 11, 2016
dongilbert
dongilbert approved these changes Oct 11, 2016
View reviewed changes
Copy link
Member

@dongilbert dongilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works well. Thanks!

@dongilbert dongilbert added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
@escopecz
Copy link
Sponsor Member

All SMS actions work fine 👍

Maybe the unpublish field might be present in the edit form, but that's just nice to have. It can be un/published from the table.

@escopecz escopecz merged commit dc8bd49 into mautic:staging Oct 12, 2016
@alanhartless alanhartless deleted the bug-2362 branch October 24, 2016 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanhartless @escopecz @dongilbert