Add a file form field #3054
Closed
Add a file form field #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job, I test it asap ! |
alanhartless
added
the
feature
alanhartless
added
the
code-review-needed
|
No review? |
|
@coudenysj @qneyrat this would be a great feature! How is the reviewing going? |
|
It's good for me |
|
@coudenysj It seemed this is incomplete. Is it possible to wrap it up so we can consider it for merger? |
|
@alanhartless Happy to do so, but I need some feedback from you guys (see the TODO items in the description). |
|
Hi, what feedback do you need? Where did you get stuck? |
escopecz
added
the
pending-feedback
Closed
|
We used this PR for #5082. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds the possibility to add file fields to forms.
Steps to test this PR:
Todo