Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding to salesforce campaign members from Mautic campaign #3753

Merged
merged 37 commits into from Apr 20, 2017

Conversation

mqueme
Copy link
Contributor

@mqueme mqueme commented Mar 24, 2017

Q A
Bug fix?
New feature? y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR creates a new fields in the push to integration action in a campaign to be able to add campaign contact to an integration campaign.

Steps to reproduce the bug:

Steps to test this PR:

1.Apply this PR, make sure you have salesforce plugin enabled and fields matched
2. create a new campaign with push to integration action.
3. Select salesforce and see new dropdown fields (Campaign, Campaign contact status)
4. Select a campaign and a campaign contact status.
5. Trigger the campaign and contacts from Mautic should be pushed to Salesforce and put in the Salesforce campaign selected as campaign members
6. Test the following scenarios:
a. If a campaign member doesn't exists Mautic should create the campaign member, if it exists is should update it with it's new status if status is sent.
b. A campaign member that was previously pushed by Mautic was deleted from a campaign in SF, the campaign member should be created again if pushed by a different campaign or same campaign in Mautic.
c. if there is a contact in Mautic and this contact's email address exists multiple times in SF (as a Lead, converted Lead or Contact) all matching SF leads or contacts should be created as campaign members in SF

@matishaladiwala matishaladiwala modified the milestone: 2.8.0 Mar 24, 2017
@mqueme mqueme added the ready-to-test PR's that are ready to test label Mar 30, 2017
@escopecz escopecz assigned escopecz and unassigned alanhartless Apr 17, 2017
@escopecz escopecz added the feature A new feature for inclusion in minor or major releases label Apr 17, 2017
@escopecz
Copy link
Sponsor Member

sf-push

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 17, 2017
@mqueme mqueme removed the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 18, 2017
@escopecz
Copy link
Sponsor Member

escopecz commented Apr 18, 2017

Now I cannot even select the status - the select is empty. Every time I select a different campaign, the new status select box is added. Please test it carefully.
campaign-sf

@escopecz escopecz added has-conflicts Pull requests that cannot be merged until conflicts have been resolved and removed pending-test-confirmation PR's that require one test before they can be merged labels Apr 20, 2017
@mqueme mqueme removed the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Apr 20, 2017
@escopecz
Copy link
Sponsor Member

While testing 6.a I cloned the campaign, changed the status and run the campaign commands. When trigger command was run, this happened:

Triggering events for campaign 13
Triggering first level events
2 total events(s) to be processed in batches of 100
 0/2 [>---------------------------]   0%

  [Doctrine\ORM\EntityNotFoundException]
  Entity of type 'Mautic\PluginBundle\Entity\IntegrationEntity' for IDs id(70158000000UFQ9AAO) was not found

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 20, 2017
@escopecz
Copy link
Sponsor Member

It all works except a part of 6.c. SF lead with the same email address as the Mautic contact that Mautic campaign pushed to SF was added to the SF campaign, but SF contact with the same email address was not added to the SF campaign.

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SF contact update will be fixed by #3800. So this works well 👍

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Apr 20, 2017
@matishaladiwala
Copy link

Works!

@matishaladiwala matishaladiwala added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Apr 20, 2017
@escopecz escopecz merged commit 762e2ce into mautic:staging Apr 20, 2017
@escopecz escopecz removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Oct 2, 2018
@escopecz escopecz removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for inclusion in minor or major releases needs-documentation PR's that need documentation before they can be merged pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants