Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash when the browser refuses to store in local storage #3798

Merged
merged 1 commit into from Apr 18, 2017
Merged

Do not crash when the browser refuses to store in local storage #3798

merged 1 commit into from Apr 18, 2017

Conversation

MaxWebmecanik
Copy link
Contributor

Q A
Bug fix? ✔️
New feature?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Viewing a page tracked my Mautic in an private Safari window causes the tracking pixel because Safari refuses to use Web Storage in private windows, throwind a QuotaExceededError

Steps to reproduce the bug:

  1. Open a page tracked by Mautic in a private Safari window
  2. Open the developer console to see the uncaught error

Steps to test this PR:

  1. Apply this PR
  2. Open a page tracked by Mautic in a private Safari window
  3. Open the developer console to see the warning

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Apr 3, 2017
@alanhartless alanhartless added this to the 2.8.0 milestone Apr 3, 2017
@escopecz escopecz self-assigned this Apr 6, 2017
@alanhartless alanhartless self-assigned this Apr 6, 2017
escopecz
escopecz approved these changes Apr 10, 2017
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Apr 10, 2017
@mqueme mqueme merged commit 8d53834 into mautic:staging Apr 18, 2017
@mqueme
Copy link
Contributor

mqueme commented Apr 18, 2017

thank you

@npracht npracht deleted the try-local-storage branch July 12, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees

@escopecz escopecz

@mqueme mqueme

Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaxWebmecanik @mqueme @escopecz @alanhartless