Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore extra themes and plugins from git #3815

Merged
merged 2 commits into from Apr 11, 2017

Conversation

isleshocky77
Copy link
Contributor

Q A
Bug fix? N
New feature? N
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? N
Deprecations? N

Description:

This is a simple pull request to update the .gitignore file to ignore plugins and themes which are not from the distribution.

Use Case

User has checked out a mautic via git and has added a symlink of their plugin or theme to the themes folder. This would also apply if a user updates the composer file to require a package of type mautic-theme or mautic-plugin which then installs into the correct directories.

Steps to test this PR:

  1. Clone mautic from github
  2. mkdir themes/test && touch themes/test/config.json
  3. git status
  4. themes/test should not have been listed

@escopecz escopecz added feature A new feature for inclusion in minor or major releases ready-to-test PR's that are ready to test labels Apr 5, 2017
@escopecz escopecz added this to the 2.8.0 milestone Apr 5, 2017
@escopecz escopecz self-assigned this Apr 6, 2017
@dongilbert dongilbert self-assigned this Apr 6, 2017
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks! 👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Apr 7, 2017
@dongilbert
Copy link
Member

+1 Thanks!

@dongilbert dongilbert merged commit c2c030f into mautic:staging Apr 11, 2017
@isleshocky77 isleshocky77 deleted the ignore-extra-themes-plugins branch October 27, 2017 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for inclusion in minor or major releases pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants