Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature GoToWebinar Add token to include the webinar link for the registrant to join #3817

Merged
merged 8 commits into from Apr 19, 2017

Conversation

virlatinus
Copy link
Contributor

@virlatinus virlatinus commented Apr 5, 2017

Q A
Bug fix? N
New feature? Y
Related user documentation PR URL mautic/documentation#170
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? N/A
Deprecations? N/A

Description:

This PR adds an extra feature to the Citrix GotoWebinar plugin: a token that can be included in a segment email and replaced with the URL to join a live webinar.

Steps to test this PR:

  1. Follow the steps in the Citrix Plugin documentation to enable the GotoWebinar plugin

  2. Create a webinar in the GotoWebinar website

  3. Create a new contact and use the emaill address to register for the new webinar

  4. Run the Citrix Sync command: php app/console mautic:citrix:sync so that the webinar information is retrieved to the database.

  5. Create a segment with a "Webinar (registered)" filter. (Note that this is mandatory, and it will be validated when trying to save the email with the token in the body)
    image

  6. Add the contact to the segment manually or by running php app/console mautic:segments:update

  7. Create a new segment email and assign the previously created segment.
    image

  8. Open the email builder and insert the GotoWebinar button token:
    image

  9. Send the email to the segment contacts.
    image

  10. The email in the new contact inbox should include a button to join the webinar with the appropiate URL for the contact.
    image

  11. The button can be styled by overriding the citrix-start-button CSS class. ie

.citrix-start-button {
  background: green !important;
}

@matishaladiwala matishaladiwala self-assigned this Apr 6, 2017
@matishaladiwala matishaladiwala modified the milestone: 2.8.0 Apr 7, 2017
@matishaladiwala matishaladiwala added the ready-to-test PR's that are ready to test label Apr 18, 2017
@escopecz escopecz added feature A new feature for inclusion in minor or major releases needs-documentation PR's that need documentation before they can be merged labels Apr 18, 2017
@virlatinus virlatinus removed the needs-documentation PR's that need documentation before they can be merged label Apr 18, 2017
@matishaladiwala
Copy link

Works for me - both button and link.

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Apr 19, 2017
@escopecz
Copy link
Sponsor Member

I was about to create a segment with my webinar registrants, but my webinar was not in the select, so I chose "any webinar" option just to save the segment and try to refresh. But when I hit save I got this error:

mautic.CRITICAL: Uncaught PHP Exception Symfony\Component\Form\Exception\InvalidArgumentException: "The value of type "array" cannot be converted to a valid array key." at vendor/symfony/form/ChoiceList/ArrayKeyChoiceList.php line 75 {"exception":"[object] (Symfony\\Component\\Form\\Exception\\InvalidArgumentException(code: 0): The value of type \"array\" cannot be converted to a valid array key. at /var/www/html/vendor/symfony/form/ChoiceList/ArrayKeyChoiceList.php:75)"} []

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 19, 2017
@virlatinus
Copy link
Contributor Author

@escopecz are you in the current staging? I just tested and it let me create a segment with filter registered to Any Webinar

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be working fine 👍

@escopecz escopecz removed the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 19, 2017
@escopecz escopecz merged commit cd6ff6c into mautic:staging Apr 19, 2017
@virlatinus virlatinus deleted the feature-gotowebinar-token branch April 19, 2017 19:01
@YannickBiet
Copy link

Hi Werner, what about the emails sent as result of a form submit ? You can in deed choose and register to the webinar using the form actions and then wanted to send directly an email to the contact containg the Button or Webinar URL ?

Seems this scenario is not supported in your PR ?
(see #3953)

@YannickBiet
Copy link

I have rewrite a full test with Form / Segments / and a new segment email linked to the segment.

The link sent is not a button and does not contain the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for inclusion in minor or major releases pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants