Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language on unsubscribe page based on contact preferred locale #3986

Merged
merged 3 commits into from May 5, 2017
Merged

Language on unsubscribe page based on contact preferred locale #3986

merged 3 commits into from May 5, 2017

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented May 3, 2017

Q A
Bug fix? y
New feature? n
Related user documentation PR URL n
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Unsubscribe page didn't apply contact preferred locale from profile.

Steps to reproduce the bug:

  1. Go to configuration set default lang to german (this step download german translations to translations direcotry)
  2. Set default lang back to english
  3. Create contact with german preferred locale
  4. Send email to contact with unsubscribe tag
  5. Open email and click to unsubscribe link
  6. Unsubscribe page is in english language

Steps to test this PR:

  1. Repeat all steps
  2. Check step 6 and german language on unsubscribe page

@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels May 4, 2017
@escopecz escopecz added this to the 2.8.1 milestone May 4, 2017
@escopecz escopecz self-assigned this May 4, 2017
escopecz
escopecz approved these changes May 4, 2017
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍 Thanks!

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label May 4, 2017
@mqueme mqueme self-assigned this May 4, 2017
@mqueme
Copy link
Contributor

mqueme commented May 5, 2017

I tried it with Spanish Language, although unsubscribe page is not fully translated it was in Spanish. Works!

@mqueme mqueme merged commit 2b93777 into mautic:staging May 5, 2017
@kuzmany kuzmany deleted the unsubscribe-lead-locale-lang branch April 7, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees

@escopecz escopecz

@mqueme mqueme

Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuzmany @mqueme @escopecz