Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracked video bugfix #4438

Closed
wants to merge 4 commits into from
Closed

Tracked video bugfix #4438

wants to merge 4 commits into from

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jul 15, 2017

Q A
Bug fix? y
New feature?
Related user documentation PR URL mautic/documentation#206
Related developer documentation PR URL
Issues addressed (#s or URLs) #4431
BC breaks?
Deprecations?

Description:

Fix for this issue #4431
Added new video attr data-mtc="1" make video trackable without gated video features. Also prevent don't convert other videos without this attr.

Steps to reproduce the bug:

  1. Add video tag to your Mautic tracking page
  2. Video is transform with mediaelements library

Steps to test this PR:

  1. Add video tag to your Mautic tracking page
  2. Add attr data-mtc="1"
  3. See If video is transform with medialements library.
    That means mautic will track video hits for contacts

@kuzmany kuzmany changed the title Video tracking bugfix Tracked video bugfix Jul 15, 2017
@kuzmany kuzmany mentioned this pull request Jul 16, 2017
@luizeof
Copy link
Member

luizeof commented Jul 16, 2017

@kuzmany hello friend ... can web filter contacts for watched some videos on segments?

@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jul 17, 2017
@kuzmany
Copy link
Member Author

kuzmany commented Jul 17, 2017

@luizeof particaly #4441

@kuzmany
Copy link
Member Author

kuzmany commented Jul 20, 2017

@escopecz could you add this bugfix to 2.9.1.
It's really annoying bug, cause transform all videos on website

@escopecz
Copy link
Sponsor Member

I'm not quite sure there will be 2.9.1 or there will be 2.10.0. But sure. It won't do any harm.

@alanhartless
Copy link
Contributor

Closed in favor of #4480

@luizeof
Copy link
Member

luizeof commented Aug 2, 2017

@kuzmany @dongilbert data-mautic-video="true" from #4480 and data-mtc="1" are the same?

@kuzmany
Copy link
Member Author

kuzmany commented Aug 2, 2017

@luizeof just data-mautic-video="true"

@shulard
Copy link
Contributor

shulard commented Aug 7, 2017

Hello @kuzmany,

What's the behaviour when user haven't installed 2.9.1 yet ?

I've just published a new WP plugin release which includes your changes : https://github.com/mautic/mautic-wordpress/releases/tag/v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants