Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes email frequency field to number type #4883

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Changes email frequency field to number type #4883

merged 1 commit into from
Dec 21, 2017

Conversation

robwent
Copy link
Contributor

@robwent robwent commented Sep 8, 2017

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #4882
BC breaks? N
Deprecations? N

Description:

The current frequency preference field is a text field and should be a number

Steps to reproduce the bug:

  1. Enable user preferences and frequency options in email configuration
  2. Check the preferences page and the field type will be text

Steps to test this PR:

  1. After the update, check the frequency field type, it should be a number field

@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@alanhartless alanhartless added pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Dec 19, 2017
@javjim javjim self-assigned this Dec 19, 2017
@Hadamcik
Copy link
Contributor

GitHub instructions to test PR did not work. If needed use:
git pull https://github.com/robwent/mautic.git '#4882'

However it doesn't work for me. Field is still type of text.

Just to be sure - I checked out Configuration -> Email settings -> Default Frequency Rule

@alanhartless
Copy link
Contributor

@dreiser Go to Mautic configuration, Email Settings, and make sure all the Yes/No toggles at the bottom are set to Yes. Add yourself as a contact and to a segment. Create a segment email using the default blank template. Send the segment email and open it. Copy the unsubscribe URL into guest session which should take you to the preference center page for the contact. Check the frequency rule number input on that page.

@escopecz escopecz self-assigned this Dec 21, 2017
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@escopecz escopecz merged commit 80ff946 into mautic:staging Dec 21, 2017
@dbhurley dbhurley removed the ready-to-test PR's that are ready to test label Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants