Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Contacts API doesn't return stage metadata for contact #5216

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Fix: Contacts API doesn't return stage metadata for contact #5216

merged 1 commit into from
Dec 19, 2017

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Oct 26, 2017

Q A
Bug fix? y
New feature?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #5214
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

  1. Add stage to Contact
  2. Create API call $contactsApi->get($contactID)
  3. dump result and see stage metadata wasn't loaded (ID, NAME..)

Steps to test this PR:

  1. Apply PR and repeat steps to reprouce
  2. Stage metadata should load

Before:

image

After PR:

image

@kuzmany kuzmany changed the title Bugfix: Contacts API doesn't return stage metadata for contact Fix: Contacts API doesn't return stage metadata for contact Nov 1, 2017
@twcarefoot
Copy link

I just ran into this issue.

When is this going to be merged?

@kuzmany
Copy link
Member Author

kuzmany commented Nov 15, 2017

@twcarefoot probably in next version 2.12

micschk
micschk approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@micschk micschk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as it should & fixes API bug

@micschk micschk mentioned this pull request Dec 6, 2017
Closed
@micschk
Copy link
Contributor

micschk commented Dec 6, 2017

Fixes #5214, fixes #4378

@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Dec 6, 2017
@escopecz escopecz added this to the 2.12.1 milestone Dec 6, 2017
escopecz
escopecz approved these changes Dec 6, 2017
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Dec 6, 2017
@alanhartless alanhartless merged commit f80356e into mautic:staging Dec 19, 2017
@dbhurley dbhurley removed the ready-to-test PR's that are ready to test label Dec 19, 2017
@kuzmany kuzmany deleted the contact-api-stage-metadata-bugfix branch April 7, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

@micschk micschk micschk approved these changes

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kuzmany @twcarefoot @micschk @alanhartless @escopecz @dbhurley