Fixed error in FocusModel where clicks and submissions were for all f… #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocus, not just the one selected
|
Works for me 👍 |
escopecz
reviewed
Nov 9, 2017
| @@ -411,14 +411,14 @@ public function getStats(Focus $focus, $unit, \DateTime $dateFrom = null, \DateT | |||
|
|
|||
| if ($focus->getType() != 'notification') { | |||
| if ($focus->getType() == 'link') { | |||
| $q = $query->prepareTimeDataQuery('focus_stats', 'date_added', ['type' => Stat::TYPE_CLICK]); | |||
| $q = $query->prepareTimeDataQuery('focus_stats', 'date_added', ['type' => Stat::TYPE_CLICK,'focus_id' => $focus->getId()]); | |||
There was a problem hiding this comment.
Fix the code standards, please.
https://travis-ci.org/mautic/mautic/jobs/295299190#L1340
There should be a space after the comma.
There was a problem hiding this comment.
Have added the space.
escopecz
added
bug
escopecz
added
ready-to-test
alanhartless
approved these changes
Dec 19, 2017
alanhartless
added
the
pending-test-confirmation
|
Fix works properly |
javjim
added
ready-to-commit
dbhurley
removed
the
ready-to-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocus, not just the one selected
Description: Focus stats were showing global clicks/submissions, not stats for just the viewed focus item.
Steps to reproduce the bug:
Steps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: