Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better error messages synccontacts command #5336

Conversation

isleshocky77
Copy link
Contributor

@isleshocky77 isleshocky77 commented Nov 15, 2017

Q A
Bug fix? N
New feature? N
Automated tests included? N
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? N
Deprecations? N

Description:

Adding better error messages when the command does not complete. Giving a list of available integrations which can be specified.

Removing some warnings from the file.

Steps to reproduce the bug:

  1. run ./app/console mautic:integration:synccontacts, notice no output
  2. run ./app/console mautic:integration:synccontacts -i SugarCrm -a '2 hours', notice error for authorization

Steps to test this PR:

Run above commands and notice nice errors and warnings and examples.

@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@alanhartless alanhartless added the bug Issues or PR's relating to bugs label Dec 13, 2017
@alanhartless alanhartless force-pushed the enhancement-integration-better-error-message branch from 6434d98 to 7b36164 Compare December 19, 2017 07:46
@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Dec 19, 2017
@javjim javjim self-assigned this Dec 19, 2017
@Hadamcik
Copy link
Contributor

Works for me, waiting for travis check

@Hadamcik Hadamcik merged commit 8202376 into mautic:staging Dec 20, 2017
@Hadamcik Hadamcik removed the pending-test-confirmation PR's that require one test before they can be merged label Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants