Fix: Custom field doesn't update Mautic custom field after create/update on Pipedrive #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzmany
changed the title
kuzmany
changed the title
alanhartless
added
bug
alanhartless
approved these changes
Dec 19, 2017
escopecz
changed the title
escopecz
reviewed
Dec 21, 2017
| @@ -63,6 +62,7 @@ public function update(array $data = []) | |||
| return $this->create($data); | |||
| } | |||
|
|
|||
| /** @var $lead LeadModel */ | |||
| $lead = $this->em->getRepository(Lead::class)->findOneById($integrationEntity->getInternalEntityId()); | |||
There was a problem hiding this comment.
@kuzmany are you sure the $lead variable is instance of LeadModel? Shouldn't it be instance of the Lead entity? If so, update the annotation and remove the LeadModel namespace please.
escopecz
added
the
pending-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This bugfix/feature has been sponsored by @Webmecanik
Contacts csustom field wasn't sync after edit in Pipedrive,
Steps to reproduce the bug:
Steps to test this PR: