Tracking lead manipulator #5379

Hadamcik · 2017-11-27T15:07:05Z

Q	A
Bug fix?	N
New feature?	Y
Automated tests included?	N
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?	N
Deprecations?	N

Description:

Log source of lead creation and identification

Steps to test this PR:

Run migrations php app/console doctrine:migrations:migrate
Create a new lead through the following sources (clear your browsers cache each time): tracking pixel on 3rd party page and via a Mautic landing page. Check the contacts created and note the created by source entry in the history should be the URL for the tracking pixel and the name of the landing page for the other.
Now submit a Mautic form embedded in a 3rd party page then also a Mautic form standalone (/form/ID). Note the identified by source entry should be the name of the form in the timeline.
Do a CRM sync and note the created by and identified source should be the CRM name
Do an import and then also manually create a contact and the created by/identified by source should be the name of the logged in user.

escopecz · 2018-01-11T10:27:17Z

app/bundles/LeadBundle/DataObject/LeadManipulator.php

+     * @param string|null $objectName
+     * @param int|null    $objectId
+     */
+    public function __construct($bundleName = null, $objectName = null, $objectId = null)


What's the reason why the first 2 params are nullable?

Because in database, they can be nullable. I thought maybe there is use case when it's possible

Good point. I was thinking we should write the code as strict as possible.

escopecz · 2018-02-08T10:26:23Z

app/bundles/LeadBundle/Entity/Lead.php

@@ -199,6 +200,9 @@ class Lead extends FormEntity implements CustomFieldEntityInterface
     */
    private $color;

+    /** @var LeadManipulator */


Can this annotation use the new lines as all of the annotations above and bellow?

ok, it's just so long..

escopecz · 2018-02-08T10:32:54Z

app/bundles/LeadBundle/Model/LeadModel.php

+            $lead->setManipulator(new LeadManipulator(
+                'lead',
+                'lead'
+            ));


Maybe I'm not understanding the task right, but how can you tell if the source of the lead is import over manual creation over UI? This code is called 4 times on 4 different places.

It's already long time, so I did not fully recalled what is bundle name and what is object name. Where do you see problem? It's manipulated from lead bundle, lead model so it's lead-lead if I'm right.

I'm not sure if it says something about UI

…ingLeadSource-2

Maxell92 · 2018-03-29T10:23:56Z

Seems that this PR is not working for me. The only difference after applying the PR is that log has different order. Could you provide us screenshot how log should look like?

Staging:

After applying PR:

Also - there are no tests for new functionality.

…ipulated lead if it is new or identified

alanhartless · 2018-03-30T01:17:59Z

I did a little work to this to address the follow issues:

It generated an entry every time a lead was saved, so I limited it to when a contact is new or when a contact is identified
Tracking pixel broke because Page is not associated with those
A forms generate.js and the mtc.js would create entires because they leveraged getCurrentLead so the tracking pixel wouldn’t register.
Needed a way to display in the timeline.

javjim · 2018-04-03T06:37:29Z

Wasnt able to test with landing pages.

CRM, Forms and embedded forms, Creating contacts and importing work properly

Maybe I am missing something in testing with landing pages...

javjim · 2018-04-03T15:31:34Z

Was able to test it and its working properly

alanhartless · 2018-04-04T13:53:55Z

@javjim-mautic So landing pages work or no?

I removed the needs documentation label because this is just a minor UI change as far as the frontend goes. We don't have existing documentation for the timeline to append to.

…kingLeadSource-2

npracht · 2018-04-11T06:44:09Z

@mleffler @dreiser could we have a documentation for that ?

alanhartless · 2018-04-11T16:03:49Z

@npracht What documentation are you looking for? All this does is display the source of the contact's identification and creation in the lead's History tab. There's not much to document.

escopecz · 2018-04-12T08:11:44Z

I added the label because some valuable info can be documented about this:

User docs:
- What sources does Mautic recognize by default?
- Is the source just info in the contact detail page or can a use create segment filters based on this? Or a campaign condition? Point trigger?
- Will it appear for old contacts too or only for the new contacts after the upgrade to 2.13.0?
Dev docs:
- How a plugin can add a new source type?

Hadamcik added 6 commits November 27, 2017 13:43

LeadManipulator + event log

9d921e3

LeadModel +setManipulator

7643b19

Fix manipulators

e88ec04

Page hits fix

f504a28

Merge event log

62c6882

Pull staging

c6add31

Hadamcik changed the title ~~WIP - Tracking lead source 2~~ Tracking lead manipulator Nov 28, 2017

Hadamcik added the ready-to-test PR's that are ready to test label Nov 28, 2017

alanhartless added this to the 2.13.0 milestone Dec 13, 2017

escopecz reviewed Jan 11, 2018

View reviewed changes

escopecz reviewed Feb 8, 2018

View reviewed changes

escopecz added feature A new feature for inclusion in minor or major releases needs-documentation PR's that need documentation before they can be merged labels Feb 8, 2018

dbhurley modified the milestone: 2.13.0 Mar 4, 2018

javjim removed the ready-to-test PR's that are ready to test label Mar 27, 2018

PHPDoc

8143b25

escopecz added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Mar 27, 2018

Hadamcik added 3 commits March 27, 2018 16:41

Pull upstream staging

7de7a6b

Log import ID

47ea3c0

Merge branch 'staging' of github.com:mautic/mautic into staging.track…

aab73cf

…ingLeadSource-2

escopecz removed the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Mar 28, 2018

Force reformat

c16a7f0

Maxell92 self-assigned this Mar 29, 2018

Fixed issue with tracking pixel where $page is null and also only man…

0ae20af

…ipulated lead if it is new or identified

alanhartless added 2 commits March 29, 2018 19:27

Display entries in the timeline

2f03a0b

Store a description to display in the timeline

ef4ba89

Fixed tests

b5423e0

alanhartless removed the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 2, 2018

mleffler assigned Hadamcik and unassigned Maxell92 Apr 2, 2018

javjim added pending-feedback PR's and issues that are awaiting feedback from the author ready-to-test PR's that are ready to test and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Apr 3, 2018

javjim added pending-feedback PR's and issues that are awaiting feedback from the author and removed ready-to-test PR's that are ready to test labels Apr 3, 2018

javjim added pending-test-confirmation PR's that require one test before they can be merged and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Apr 3, 2018

alanhartless removed the needs-documentation PR's that need documentation before they can be merged label Apr 4, 2018

Hadamcik added 5 commits April 5, 2018 04:21

LandingPage tests

b5ef6f8

Fix tests + skip second visit test

8b5b79c

Merge branch 'staging' of github.com:Dreiser/mautic into staging.trac…

855863b

…kingLeadSource-2

Pull staging

f9bf1ed

Set current lead missing - fix

e3d2e1f

Hadamcik removed needs-automated-tests PR's that need automated tests before they can be merged pending-test-confirmation PR's that require one test before they can be merged labels Apr 5, 2018

mleffler merged commit 182a711 into mautic:staging Apr 5, 2018

escopecz added the needs-documentation PR's that need documentation before they can be merged label Apr 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking lead manipulator #5379

Tracking lead manipulator #5379

Hadamcik commented Nov 27, 2017 •

edited by alanhartless

escopecz Jan 11, 2018

Hadamcik Mar 27, 2018

escopecz Mar 27, 2018

escopecz Feb 8, 2018

Hadamcik Mar 27, 2018

escopecz Feb 8, 2018

Hadamcik Mar 27, 2018

Maxell92 commented Mar 29, 2018 •

edited

alanhartless commented Mar 30, 2018 •

edited

javjim commented Apr 3, 2018

javjim commented Apr 3, 2018

alanhartless commented Apr 4, 2018

npracht commented Apr 11, 2018

alanhartless commented Apr 11, 2018

escopecz commented Apr 12, 2018 •

edited

Tracking lead manipulator #5379

Tracking lead manipulator #5379

Conversation

Hadamcik commented Nov 27, 2017 • edited by alanhartless

Description:

Steps to test this PR:

escopecz Jan 11, 2018

Choose a reason for hiding this comment

Hadamcik Mar 27, 2018

Choose a reason for hiding this comment

escopecz Mar 27, 2018

Choose a reason for hiding this comment

escopecz Feb 8, 2018

Choose a reason for hiding this comment

Hadamcik Mar 27, 2018

Choose a reason for hiding this comment

escopecz Feb 8, 2018

Choose a reason for hiding this comment

Hadamcik Mar 27, 2018

Choose a reason for hiding this comment

Maxell92 commented Mar 29, 2018 • edited

alanhartless commented Mar 30, 2018 • edited

javjim commented Apr 3, 2018

javjim commented Apr 3, 2018

alanhartless commented Apr 4, 2018

npracht commented Apr 11, 2018

alanhartless commented Apr 11, 2018

escopecz commented Apr 12, 2018 • edited

Hadamcik commented Nov 27, 2017 •

edited by alanhartless

Maxell92 commented Mar 29, 2018 •

edited

alanhartless commented Mar 30, 2018 •

edited

escopecz commented Apr 12, 2018 •

edited