Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt-remove is required for build process #5382

Closed

Conversation

isleshocky77
Copy link
Contributor

Currently it's documented that grunt compile-less is sometimes needed for compiling assets. However, the grunt file depends on grunt-remove which is not included by the npm setup.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N/A
BC breaks? N
Deprecations? N

Description:

Update NPM's package.json to require grunt-remove

Steps to reproduce the bug:

  1. Clone fresh repo
  2. run composer install, npm install, grunt compile-less
  3. Note error

Steps to test this PR:

  1. Clone fresh repo
  2. run composer install, npm install, grunt compile-less
  3. Note successful execution

@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@alanhartless alanhartless added the bug Issues or PR's relating to bugs label Dec 13, 2017
@alanhartless
Copy link
Contributor

This has been fixed by #4915

@isleshocky77 isleshocky77 deleted the fix-grunt-dependency-error branch March 7, 2018 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants