Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapped company when pushing to Connectwise causes error #5424

Merged
merged 4 commits into from
Dec 8, 2017

Conversation

alanhartless
Copy link
Contributor

Q A
Bug fix? y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Connectwise requires a company reference ID instead of company name when pushing via a campaign. But if company is not mapped, it won't be pulled from CW to Mautic. So this removes company when pushing until proper reference mapping is written.

Steps to reproduce the bug:

  1. Configure the CW plugin
  2. Map required plus company
  3. Create campaign to push to CW
  4. Create a new contact and add to campaign
  5. Run the campaign and note the CW error

Steps to test this PR:

  1. Repeat and this time it'll push

@alanhartless alanhartless added the bug Issues or PR's relating to bugs label Dec 8, 2017
@alanhartless alanhartless added this to the 2.12.1 milestone Dec 8, 2017
@escopecz
Copy link
Sponsor Member

escopecz commented Dec 8, 2017

I'm getting an error message bellow when create a campaign action "Push contact to integration" and select "Connectwise". It's happening on staging and when I check out this PR and clear cache.

mautic.CRITICAL: Uncaught PHP Exception Mautic\PluginBundle\Exception\ApiErrorException: "404 not found error" at plugins/MauticCrmBundle/Api/ConnectwiseApi.php line 56 {"exception":"[object] (Mautic\\PluginBundle\\Exception\\ApiErrorException(code: 0): 404 not found error at /plugins/MauticCrmBundle/Api/ConnectwiseApi.php:56)"} []

Edit: This was caused by plugin misconfiguration

@escopecz escopecz self-assigned this Dec 8, 2017
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. The error is gone and the contact got pushed to CW.

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Dec 8, 2017
@dongilbert dongilbert merged commit 521419e into mautic:staging Dec 8, 2017
@alanhartless alanhartless deleted the bug-cw-company-push branch January 5, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants