Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX fix: Campaign action buttons #5434

Merged
merged 1 commit into from
Dec 20, 2017
Merged

UX fix: Campaign action buttons #5434

merged 1 commit into from
Dec 20, 2017

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Dec 11, 2017 •
edited
Loading

Q A
Bug fix? y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #5128
BC breaks?
Deprecations?

This bugfix/feature has been sponsored by @Webmecanik

Description:

Based on this issue #5128
Buttons were styled just for english language.
French language was ugly styled.
This PR fixed it.

Steps to reproduce the bug:

  1. Change your settings to French language
  2. Create Campaign and open builder
  3. See bad UX styled buttons on the right corner (apply/close)

Steps to test this PR:

1: Apply PR and call php app/console m:a:g
2 Repeat all steps to reproduce bug
3. See well UX styled button

Before

image

After

image

@kuzmany kuzmany mentioned this pull request Dec 11, 2017
Closed
@escopecz escopecz added ready-to-test PR's that are ready to test user-experience Anything related to related to workflows, feedback, and navigation labels Dec 13, 2017
@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@javjim
Copy link

javjim commented Dec 19, 2017

getting mautic.core.language.helper.invalid.language error..

@alanhartless
Copy link
Contributor

@javjim-mautic I think that may have something to do with your local not being able to fetch the language. This worked for me.

@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Dec 19, 2017
@javjim
Copy link

javjim commented Dec 19, 2017

working properly for me

@javjim javjim added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Dec 19, 2017
@javjim javjim assigned javjim and unassigned javjim Dec 19, 2017
@alanhartless alanhartless merged commit bc5ee3d into mautic:staging Dec 20, 2017
@dbhurley dbhurley removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Dec 20, 2017
@kuzmany kuzmany deleted the campaign-builder-apply-css-bug branch April 7, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
user-experience Anything related to related to workflows, feedback, and navigation
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kuzmany @javjim @alanhartless @escopecz @dbhurley