Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed is:mine command and added user session support for functional tests #5450

Merged
merged 15 commits into from
Dec 19, 2017
Merged

Fixed is:mine command and added user session support for functional tests #5450

merged 15 commits into from
Dec 19, 2017

Conversation

alanhartless
Copy link
Contributor

@alanhartless alanhartless commented Dec 13, 2017 •
edited
Loading

Q A
Bug fix? y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #3734 #3735
BC breaks?
Deprecations?

Description:

The is:mine search command would throw an exception because of bad DQL (createdby is not an association). This fixes that.

This also adds support to the test environment for user authorization for the browser-kit client to leverage with functional tests.

Steps to reproduce the bug:

  1. Go to a list such as campaigns and use is:mine in the filter and note the error.

Steps to test this PR:

  1. Repeat and only yours would show

@alanhartless alanhartless added bug Issues or PR's relating to bugs needs-automated-tests PR's that need automated tests before they can be merged labels Dec 13, 2017
@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@alanhartless alanhartless mentioned this pull request Dec 13, 2017
Closed
@alanhartless alanhartless added ready-to-test PR's that are ready to test and removed needs-automated-tests PR's that need automated tests before they can be merged labels Dec 13, 2017
@alanhartless alanhartless changed the title Fixed is:mine command Fixed is:mine command and added user session support for functional tests Dec 14, 2017
@javjim
Copy link

javjim commented Dec 18, 2017

Tested, and fixes issue

@javjim javjim added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Dec 18, 2017
@javjim javjim assigned javjim and unassigned javjim Dec 19, 2017
@Hadamcik
Copy link
Contributor

Works for me

@Hadamcik Hadamcik removed the pending-test-confirmation PR's that require one test before they can be merged label Dec 19, 2017
@Hadamcik Hadamcik merged commit 69035ed into mautic:staging Dec 19, 2017
@alanhartless alanhartless deleted the is-mine-fix branch January 5, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hadamcik Hadamcik Hadamcik approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanhartless @javjim @Hadamcik