Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5532 problem with MailjetTransport header X-MJ-CUSTOMID #5534

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

XRaccourci
Copy link
Contributor

Q A
Bug fix? #5532
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Fixes issue #5532
Delete the header 'X-MJ-CUSTOMID' before rewriting the correct header in MailjetTransport.

Steps to reproduce the bug:

  1. Create a segment
  2. Add two leads at least in this segment
  3. Create a manual email and set the precedent segment
  4. Add log in Swift_Transport_AbstractSmtpTransport in the end of send function. Log this => $message->getHeaders()->get('X-MJ-CUSTOMID')->toString() before return.
  5. Send this email
  6. View the log. X-MJ-CUSTOMID is the same for the two differents emails. It's normally different because X-MJ-CUSTOMID is defined like this "leadIdHash-email". After fixes, the header is correct.

Steps to test this PR:

  1. Apply PR
  2. Repeat Steps 1-6 above
  3. Notice value is correct

List deprecations along with the new alternative:

List backwards compatibility breaks:

Copy link
Member

@dbhurley dbhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dbhurley dbhurley added bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Jan 8, 2018
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@escopecz escopecz added this to the 2.12.2 milestone Jan 8, 2018
@escopecz escopecz removed pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Jan 8, 2018
@escopecz escopecz merged commit 7f629a3 into mautic:staging Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants