Froala code view editor - image CSS getting stripped

[GaberNeighbor]

Q	A
Bug fix?	x
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Removing call to function in Froala image.js that removes many common style declarations and replaces them with a broken class.

Steps to reproduce the bug:

1. Create new email
2. Open builder
3. Insert image in text-slot
4. Open code view
5. Give image inline CSS: style="margin: 0; float: right; display: block; z-index: 1; position: relative; overflow: auto; vertical-align: top"
6. Close code view, then re-open
7. Observe that all inline CSS has been stripped from the image (very bad for emails).

Steps to test this PR:

1. Repeat steps 1-6 above
2. Observe that all inline CSS is no longer removed from the image

[escopecz]

It's never a good idea to hack a library. Because once that library gets updated it will remove the hack. We use an older version of Froala. Maybe there is fix for this issue already in the new version. Or there is hopefully some configuration option on how to avoid it. Could you please look at another option?

[kuzmany]

What about #5174 ? Works for you?
Don't forget run php app/console m:a:g after apply PR to regenerate assets.

[GaberNeighbor]

@kuzmany #5174 is a better solution than mine. @escopecz does #5174 work for you?

[escopecz]

I'll close this PR. Let's discuss this issue at #5174 too since the solution will be very similar.