Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL install requirement check #5621

Merged
merged 2 commits into from Mar 26, 2018
Merged

OpenSSL install requirement check #5621

merged 2 commits into from Mar 26, 2018

Conversation

Hadamcik
Copy link
Contributor

Q A
Bug fix? N
New feature? Y
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Adds check to installation process - if mcrypt is missing, openssl is checked if it's enabled and working (with access to /dev/random or /dev/urandom)

Steps to test this PR:

  1. Test installation with mcrypt without openssl
  2. Should work
  3. Test installation with mcrypt and with openssl (without access to /dev/random or /dev/urandom)
  4. Should work
  5. Test installation without mcrypt and with openssl (without access to /dev/random or /dev/urandom)
  6. Should now work
  7. Test installation without mcrypt and with openssl (with access to /dev/random or /dev/urandom)

@Hadamcik Hadamcik added the ready-to-test PR's that are ready to test label Jan 22, 2018
@Hadamcik Hadamcik added this to the 2.12.2 milestone Jan 22, 2018
@escopecz escopecz added the user-experience Anything related to related to workflows, feedback, and navigation label Jan 23, 2018
@escopecz escopecz self-assigned this Jan 23, 2018
@escopecz
Copy link
Sponsor Member

This seems to be working well. If I disable mcrypt on staging I get this error:
screen shot 2018-01-23 at 15 44 19
But this PR doesn't force me to install mcrypt which is a good thing. I'm not quite sure how to easily test the scenario "With mcrypt and without openssl" since openssl must be compiled with php itself. Don't want to mess with my setup that much that I reinstall php.

I'm not quite sure how to configure open_basedir to test /dev/random. With all my configuration tests it doesn't load the installation page at all.

But anyway, this is working for the tests I was able to do. 👍

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jan 23, 2018
@alanhartless alanhartless modified the milestones: 2.12.2, 2.13.0 Jan 24, 2018
@daikiejp
Copy link

daikiejp commented Feb 6, 2018

When this update will release? I got same problem and message....

@Maxell92 Maxell92 self-assigned this Mar 26, 2018
Copy link
Contributor

@Maxell92 Maxell92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@mautibot mautibot added the code-review-needed PR's that require a code review before merging label Mar 26, 2018
@Maxell92 Maxell92 merged commit 14e1919 into mautic:staging Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged user-experience Anything related to related to workflows, feedback, and navigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants