Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Dynamics FetchLeads - update #5674

Open
wants to merge 26 commits into
base: 4.x
Choose a base branch
from

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Feb 3, 2018

Q A
Bug fix?
New feature? y
Automated tests included?
Related user documentation PR URL tba
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

This bugfix/feature has been sponsored by @Webmecanik

Description:

Follow up to #5229 (@npracht should close old PR)

This PR add the ability for users of Microsoft Dynamics users

  • fetch leads from leads Microsoft Dynamics object (contacts and companies are supported so far)
  • resolve duplicate contact if contact exists on both sides Mautic and Microsoft Dynamics
    • we're trying find existed contact and if exists, we just create integration entity and update contact fields based on plugin settings

image

Steps to test this PR:

  1. Steps to test this PR:
  2. Connect your integration (follow documentation)
  3. In the feature tab, enable Leads
  4. Create a lead in you MSD account
  5. Launch command
  6. See your lead in mautic contacts
  7. Create contacts on both sides Mautic and Microsoft Dynamics
  8. Try setup plugin, especially new option Mautic contacts pushed to Dynamics CRM object and Try find exists contact during the push to Dynamics CRM (see image example above)
  9. Test if works properly

@mautibot mautibot added the code-review-needed PR's that require a code review before merging label Feb 3, 2018
@kuzmany
Copy link
Member Author

kuzmany commented Feb 3, 2018

Label: WIP

@mautibot mautibot added the WIP PR's that are not ready for review and are currently in progress label Feb 3, 2018
@kuzmany
Copy link
Member Author

kuzmany commented Feb 3, 2018

Label: Feature Request

@mautibot mautibot added the feature A new feature for inclusion in minor or major releases label Feb 3, 2018
@kuzmany
Copy link
Member Author

kuzmany commented Feb 6, 2018

Label: WIP

@mautibot mautibot removed the WIP PR's that are not ready for review and are currently in progress label Feb 6, 2018
@kuzmany
Copy link
Member Author

kuzmany commented Feb 6, 2018

Label: Ready to test

@mautibot mautibot added the ready-to-test PR's that are ready to test label Feb 6, 2018
@npracht
Copy link
Member

npracht commented Feb 7, 2018

I start testing !

@dbhurley dbhurley added this to the 2.13.0 milestone Mar 4, 2018
@dbhurley
Copy link
Member

Due to the work being discussed in removing plugins from core and especially extracting the CRM plugins from core I recommend this work be held out of 2.13. This should be part of the discussion when evaluating how CRM plugins are handled, however, additions to Mautic core CRM is being restricted in the immediate as a result.

_eg. This should live in a mautic-dynamics repository instead of being part of the core release.

@dbhurley dbhurley removed this from the 2.13.0 milestone Mar 25, 2018
@dbhurley dbhurley added plugin Anything related to plugins and removed ready-to-test PR's that are ready to test labels Mar 25, 2018
@npracht
Copy link
Member

npracht commented Mar 26, 2018

@dbhurley clear. Thanks.

@escopecz escopecz added this to the 2.15.0 milestone Sep 10, 2018
@npracht npracht added this to To do in Testing 2.15.0 Oct 16, 2018
@RCheesley RCheesley changed the base branch from 3.2 to features January 19, 2021 17:19
@RCheesley
Copy link
Sponsor Member

Still has outstanding test coverage issues, I am willing to bump this one more feature release to Mautic 4 and if we have not merged it by then we will close the PR.

@RCheesley RCheesley modified the milestones: 3.3.0, Mautic 4.0 Feb 13, 2021
@RCheesley RCheesley modified the milestones: 4.0-alpha, 4.0-beta Mar 29, 2021
@npracht npracht modified the milestones: 4.0-beta, 4.0-rc May 14, 2021
@RCheesley RCheesley removed this from the 4.0-rc milestone May 22, 2021
@stale
Copy link

stale bot commented Aug 20, 2021

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Aug 20, 2021
@stale
Copy link

stale bot commented Sep 3, 2021

This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions.

@stale stale bot closed this Sep 3, 2021
@kuzmany kuzmany reopened this Sep 4, 2021
@stale stale bot removed the stale Issues which have not received an update within 90 days label Sep 4, 2021
@RCheesley RCheesley changed the base branch from features to 4.x September 7, 2021 11:06
@stale
Copy link

stale bot commented Dec 6, 2021

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Dec 6, 2021
@stale
Copy link

stale bot commented Dec 21, 2021

This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions.

@stale stale bot closed this Dec 21, 2021
@kuzmany kuzmany reopened this Jan 3, 2022
@stale stale bot removed the stale Issues which have not received an update within 90 days label Jan 3, 2022
…bjects-update

# Conflicts:
#	plugins/MauticCrmBundle/Api/DynamicsApi.php
#	plugins/MauticCrmBundle/Integration/DynamicsIntegration.php
@RCheesley RCheesley added needs-rebase PR's that need to be rebased has-conflicts Pull requests that cannot be merged until conflicts have been resolved labels Aug 4, 2023
@RCheesley
Copy link
Sponsor Member

Conflicts & rebase needed. Pinging @mautic/dynamics-tiger-team - it's an old PR so would be good to check if it's still required!

@escopecz
Copy link
Sponsor Member

escopecz commented Apr 2, 2024

@kuzmany could you please check if this issue was fixed with #13208?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The PR contributors have signed the contributors agreement enhancement Any improvement to an existing feature or functionality has-conflicts Pull requests that cannot be merged until conflicts have been resolved needs-documentation PR's that need documentation before they can be merged needs-rebase PR's that need to be rebased plugin Anything related to plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet