Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CRM not mapping company custom fields for new companies #5842

Merged
merged 1 commit into from Mar 21, 2018

Conversation

alanhartless
Copy link
Contributor

Q A
Bug fix? Y
New feature?
Automated tests included? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Companies created from SF (or any CRM) in Mautic would not map any values unless it was the ones used to identify the company (name, state, etc). If the CRM's company name was not mapped to the core Company Name field, an empty company would be created

Steps to reproduce the bug:

  1. Setup the SF CRM sync
  2. Create two new company custom field in Mautic
  3. Create a few new Accounts in SF
  4. Map the new company custom field to something from SF
  5. Map the Account Name to the second custom field
  6. Run the sync and notice that empty companies are created

Steps to test this PR:

  1. Delete the empty companies
  2. Apply the PR
  3. Run the sync again
  4. Companies will be created with the mapped data but the core Company Name is at least not empty although it may not be expected because Mautic's core Company Name wasn't mapped
  5. Delete the companies
  6. Map the SF Account Name to Mautic's core Company Name
  7. Sync again
  8. All field values should now be hydrated in the company created in Mautic

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Mar 21, 2018
@alanhartless alanhartless added this to the 2.13.0 milestone Mar 21, 2018
@mautibot mautibot added the code-review-needed PR's that require a code review before merging label Mar 21, 2018
@javjim
Copy link

javjim commented Mar 21, 2018

Able to reproduce bug and fix

@javjim javjim added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Mar 21, 2018
@escopecz escopecz self-assigned this Mar 21, 2018
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Thanks!

@escopecz escopecz removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged review labels Mar 21, 2018
@escopecz escopecz merged commit aea0732 into mautic:staging Mar 21, 2018
@mautibot mautibot added the code-review-needed PR's that require a code review before merging label Mar 21, 2018
@alanhartless alanhartless deleted the bug-sf-empty-companies branch May 24, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants