Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display list of contacts on click in Click stats table across all channel #5849

Merged
merged 5 commits into from Jul 17, 2018

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Mar 21, 2018

Q A
Bug fix? Yes
New feature? Yes
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #1883
BC breaks?
Deprecations?

Description:

This PR added clickable number of unique clicks across all channels (email, sms, notification, dynamicContent) Click stats table. Number of unique clicks will redirect to contact list with related filter. Same like search commands: email_sent, email_read added few months ago. This PR added new search commands page_id, page_source, page_source_id
Also this PR fixed issue if somebody wrote same search command twice and more time. This lines fixed it https://github.com/mautic/mautic/pull/5849/files#diff-3fa38c644457bfa255aabbc8bd7e5291R1090

Preview in email details template:

image

Steps to reproduce the bug:

  1. Try search with two same commands
    image
  2. If you use dev mode, error return. Or check logs for error something like

The given alias xx is not unique in FROM

Steps to test this PR:

  1. Apply PR and repeat steps
  2. See no error

Steps to test this feature request:

  1. Apply PR and create email, notification, sms, dynamicContent with some click statistics
  2. Go to all created entity to details
  3. Scroll to click counts table and click on any number of unique clicks
  4. Click should redirect to contacts page with search commands and related results
  5. Check if all results works properly

@mautibot mautibot added code-review-needed PR's that require a code review before merging Feature labels Mar 21, 2018
@kuzmany
Copy link
Member Author

kuzmany commented Mar 21, 2018

Label: Ready to test

@mautibot mautibot added the ready-to-test PR's that are ready to test label Mar 21, 2018
@kuzmany kuzmany changed the title Display list of contacts in email click stats table Display list of contacts in emails click stats table Mar 21, 2018
@dbhurley dbhurley removed the Feature label Mar 22, 2018
@kuzmany kuzmany changed the title Display list of contacts in emails click stats table Display list of contacts on click in Click stats table in every channel Mar 23, 2018
@kuzmany kuzmany changed the title Display list of contacts on click in Click stats table in every channel Display list of contacts on click in Click stats table across all channel Mar 23, 2018
@AmitBFG
Copy link

AmitBFG commented Apr 17, 2018

Hi,

I have been waiting for this feature, where i can drill down to email clicks. How can i implement this in my existing mautic environment?

I'm currently on v2.12.1

Thanks
Amit

@kuzmany
Copy link
Member Author

kuzmany commented Apr 17, 2018

@AmitBFG manually with change exactly lines https://github.com/mautic/mautic/pull/5849/files, by git apply or by https://github.com/mautic/mautic-tester

@ghost
Copy link

ghost commented Apr 17, 2018

@kuzmany if we do it manually with changes shown in commit, would any future upgrade process fail from a low to high risk perspective? Question mainly for a production enviroment.

@kuzmany
Copy link
Member Author

kuzmany commented Apr 17, 2018

Need update with every core update. It's risky, need tech skill guy in your team.
Then not recommended do it.

@npracht
Copy link
Member

npracht commented May 24, 2018

Label: Bug

@npracht
Copy link
Member

npracht commented May 24, 2018

Label: Enhancement

@npracht
Copy link
Member

npracht commented May 24, 2018

@alanhartless & @escopecz this feature is awesome and wished by every mautic user for a looooong time.
Can we consider it as candidate for 2.14 ?

Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a user perspective it works !

@escopecz escopecz added this to the 2.14.0 milestone May 24, 2018
@npracht npracht added the enhancement Any improvement to an existing feature or functionality label Jun 1, 2018
@ghost
Copy link

ghost commented Jun 13, 2018

👍
Tested and works
image

@npracht npracht added the pending-test-confirmation PR's that require one test before they can be merged label Jun 28, 2018
@dongilbert dongilbert merged commit b8c0c56 into mautic:staging Jul 17, 2018
@mautibot
Copy link

mautibot commented Apr 8, 2022

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/add-form-source-filter-on-contacts-view/23694/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants