Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Type namespace added to BodyParser #5881

Merged

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Mar 30, 2018

#//: # ( Please answer the following questions: )

Q A
Bug fix? Y
New feature? N
Automated tests included? /
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) https://mautic.slack.com/archives/C02HU8BUT/p1522403718000207
BC breaks? N
Deprecations? N

Description:

Just saw this error message in the Slack linked above:

[Symfony\Component\Debug\Exception\ClassNotFoundException]                                                                                                                        
 Attempted to load class "Type" from namespace "Mautic\EmailBundle\MonitoredEmail\Processor\Bounce".                                                                                
 Did you forget a "use" statement for e.g. "JMS\Serializer\Annotation\Type", "Doctrine\DBAL\Types\Type", "Aws\DynamoDb\Enum\Type", "Symfony\Component\Validator\Constraints\Type"  
 or "Mautic\EmailBundle\MonitoredEmail\Processor\Bounce\Definition\Type"?

Somewhere was clearly missing namespace. I think I found the right and only file.

Steps to reproduce the bug:

  1. Don't actually know. Author described the bug report it like this:

I recently started to have issues with bounce management

Steps to test this PR:

  1. I think that a code review is enough for this PR to be merged. It's kinda obvious. And it can't break anything anyway.

@mautibot mautibot added the code-review-needed PR's that require a code review before merging label Mar 30, 2018
@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Mar 30, 2018
@escopecz escopecz added this to the 2.13.1 milestone Mar 30, 2018
@jsimoes
Copy link

jsimoes commented Mar 30, 2018

Tested with my setup and it fixes the issue. thanks

@galvani galvani self-requested a review March 31, 2018 07:31
@mautibot mautibot removed the code-review-needed PR's that require a code review before merging label Mar 31, 2018
Copy link
Contributor

@galvani galvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIssing use is there

@mautibot mautibot added the code-review-needed PR's that require a code review before merging label Mar 31, 2018
@galvani galvani added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Mar 31, 2018
@Maxell92 Maxell92 self-assigned this Apr 9, 2018
@mautibot mautibot added the code-review-needed PR's that require a code review before merging label Apr 9, 2018
@Maxell92 Maxell92 removed the code-review-needed PR's that require a code review before merging label Apr 9, 2018
@mleffler mleffler merged commit f5b49fe into mautic:staging Apr 10, 2018
@dbhurley dbhurley removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants