-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/email use owner setting #6071
Enhancement/email use owner setting #6071
Conversation
…flag instead of global config setting
@Travisimo Thanks for doing this! I haven't tested this yet but just pointed out that it broke one of the tests. https://travis-ci.org/mautic/mautic/builds/377062056?utm_source=github_status&utm_medium=notification Let's make sure it didn't introduce a bug. |
@alanhartless Of course! Thanks for the suggestion and help along the way. The bug has been resolved. |
Label: Enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some tiny issues. Please resolve them and I'll test it then.
@escopecz thanks for the feedback! I will get to work on fixing those issues. |
@escopecz I have fixed the issues you have pointed out |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tmoheit.
|
I've resolved conflicts. |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tmoheit.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tmoheit.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tmoheit.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tmoheit.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tmoheit.
|
Updated the docs to reflect the 3.3 release, should be good to go once branch is updated and tests are passing. |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tmoheit.
|
* Add documentation for mautic/mautic#6071 * Update pages/07.Channels/02.Emails/04.Mailer is owner/docs.en.md * Update pages/07.Channels/02.Emails/04.Mailer is owner/docs.en.md * Update pages/07.Channels/02.Emails/04.Mailer is owner/docs.en.md
* Add documentation for mautic/mautic#6071 * Update pages/07.Channels/02.Emails/04.Mailer is owner/docs.en.md * Update pages/07.Channels/02.Emails/04.Mailer is owner/docs.en.md * Update pages/07.Channels/02.Emails/04.Mailer is owner/docs.en.md
Please be sure you are submitting this against the staging branch.
Description: This is a new pull request based off of discussion from PR #6004. The "Use Owner As Mailer" setting has been added to the email template, adding more refined control for emails. The global config setting will now only act as a default settings for new emails. Emails can now individually have this feature toggled.
Steps to reproduce the bug:
Steps to test this PR:
Apply this PR and then apply the migration using
bin/console doctrine:migrations:execute --up 20180508202930
Revoke the migration if required using
bin/console doctrine:migrations:execute --down 20180508202930
List deprecations along with the new alternative:
List backwards compatibility breaks: