Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Scheduled Campaign Events without Contacts #6207

Merged
merged 5 commits into from
Jul 6, 2018
Merged

[Bugfix] Scheduled Campaign Events without Contacts #6207

merged 5 commits into from
Jul 6, 2018

Conversation

dongilbert
Copy link
Member

@dongilbert dongilbert commented Jun 12, 2018 •
edited

#Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Scheduled campaign events without any contacts in them were still being executed. This PR fixes that.

Steps to reproduce the bug:

Steps to test this PR:

  1. Run Unit Tests cd app && ../bin/phpunit --filter="ScheduledContactFinder"

@dongilbert dongilbert force-pushed the dongilbert/bugfix-campaign-scheduled-contacts branch 2 times, most recently from 1415fdd to f87b614 Compare June 12, 2018 15:50
@dongilbert dongilbert force-pushed the dongilbert/bugfix-campaign-scheduled-contacts branch from f87b614 to 5e0df97 Compare June 12, 2018 15:52
@dongilbert dongilbert force-pushed the dongilbert/bugfix-campaign-scheduled-contacts branch from 5e0df97 to 53803bc Compare June 12, 2018 15:53
@dongilbert dongilbert changed the title Dongilbert/bugfix campaign scheduled contacts [Bugfix] Scheduled Campaign Events without Contacts Jun 12, 2018
@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jun 12, 2018
@alanhartless alanhartless added this to the 2.14.0 milestone Jun 12, 2018
alanhartless
alanhartless approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@alanhartless alanhartless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests are passing meaning that the functional tests that handle scheduled events still work even with this fix. And the new test passes. So +1

@npracht npracht added the pending-test-confirmation PR's that require one test before they can be merged label Jun 18, 2018
@alanhartless alanhartless mentioned this pull request Jul 3, 2018
Merged
@javjim
Copy link

javjim commented Jul 6, 2018

works perfectly

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Jul 6, 2018
@alanhartless alanhartless merged commit a9c7114 into mautic:staging Jul 6, 2018
@escopecz escopecz removed ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dongilbert @javjim @alanhartless @escopecz @npracht