New campaign action to jump to another event in the current campaign #6215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d if done by the campaign change action or without if removed by a filter.
dongilbert
added
user-interface
dongilbert
commented
Jun 15, 2018
| $event, | ||
| $viewParams = array_merge($viewParams, [ | ||
| 'form' => $this->setFormTheme($form, 'MauticCampaignBundle:Campaign:index.html.php', $formThemes), | ||
| 'eventHeader' => $event['settings']['label'], |
There was a problem hiding this comment.
These are already translated in the CampaignBuilderEvent when adding the action: https://github.com/mautic-internal/mautic/blob/staging.campaign-jump-to-event/app/bundles/CampaignBundle/Event/CampaignBuilderEvent.php#L239
…not all jump-to events are handled properly. Will need to refactor this a bit.
…sure jump to events are handled last
… getting mixed up
…ue: '165,2009'` error
… date/time is used only to evaluate inactivity
alanhartless
force-pushed
the
staging.campaign-jump-to-event
branch
from
7fa94b8
to
9138d68
Compare
alanhartless
changed the title
alanhartless
added
ready-to-test
|
@alanhartless Your changes to this look great. Thanks! |
dbhurley
approved these changes
Jul 17, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
This is dependent on and includes #6132. It should be merged first.
Instead of requiring users to duplicate decision trees within a campaign, we should be able to allow the user to specify another event in the campaign to jump to. This will reduce complexity within the campaign builder view and make campaigns easier to manage overall.
TODO:
jumpToTargetproperty on jump events when cloning.If a contact jumps to multiple locations with decisions, pending decisions prior to the jump will be ignored (will not fix as it's an outlier case and not easily supported without further significant refactoring)Steps to test this PR: