Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add applyDateFilters to CampaignEventLog report #6361

Merged
merged 1 commit into from Sep 4, 2018
Merged

Add applyDateFilters to CampaignEventLog report #6361

merged 1 commit into from Sep 4, 2018

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jul 26, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Notice with work with Reports with Campaign Events that date range didn't apply to results.
This PR fixed it

Steps to reproduce the bug:

  1. Create report: Campaigns > Campaign Events
  2. Apply date range filter for short period, maybe 1-2 days
  3. See report show all data and not apply date range filter

Steps to test this PR:

  1. Repeat all steps and see If results are displayed just for date what was selected

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Jul 26, 2018
@kuzmany kuzmany added this to the 2.14.1 milestone Jul 26, 2018
@heathdutton heathdutton added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Sep 4, 2018
@heathdutton heathdutton merged commit 5d9f8ce into mautic:staging Sep 4, 2018
@escopecz escopecz removed ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heathdutton heathdutton heathdutton approved these changes

Assignees
No one assigned
Labels
enhancement Any improvement to an existing feature or functionality
Projects
None yet
Milestone
2.14.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuzmany @heathdutton @escopecz