Segment deletion validation.

[mitresh95]

Description:

We need to validate if some other entity depends on the segment being deleted. Currently there is no validation which leads to segment processing errors when dependent segments are deleted.

Steps to reproduce the bug:

1. Apply membership filters on a segment.
2. Attempt to delete the segment on which the previous segment was dependent. It will be deleted.

Steps to test this PR:

1. Checkout to the branch in PR.
2. Follow the same steps as to reproduce the issue and now it would prevent the deletion and provide the flash message.

[npracht]

Hi @mitresh95 this is an awesome improvement !!
Does it also work if the segment is using in a campaign or a segment email or report filter ?

[kuzmany]

Doesn' work for me. Tested with Mautibox https://mautibox.com/6566/s/segments

If I use delete button, segment deleted, but no flash message.
If I use batch delete, there is flash message (translations missing), but segment is delete either.

[mitresh95]

Hi @npracht Thank you! And sorry for the delayed response. So if you mean to say that if a contact segment is used in the Campaigns or else, then no, right now this feature just checks for segment inter-dependency. So while deletion it will be only checked with other segments weather or not other segment/s are dependent on it.

[mitresh95]

@kuzmany This is strange. Checking out the branch in my local environment and testing it gave me proper results. Let me look it up and see what is wrong here. Thanks!

[npracht]

@mitresh95 it would be awesome that it is checked in any other type of entity (points, campaigns, email, etc.)

[mleffler]

Agree, Norman, but this is a step in the right direction :). Thx for commenting.

[mleffler]

@kuzmany let us know if this has resolved in mautibox. We are running it and it is working fine.

[mleffler]

@mitresh95 Pls fix the conflicts.

[kuzmany]

@mleffler Maybe I am wrong, but I didn't see translation for mautic.lead.list.error.cannot.delete.batch anyway in this PR or in actual staging. I am not sure If the PR is committed complete

[kuzmany]

Also as I see the code apply just for batchDeleteAction()
https://github.com/mautic/mautic/pull/6566/files#diff-a22caf80768ad2745ddc23b23520ab94L531

Where is the check for deleteAction() ?

[kuzmany]

Also there is no return if toBeDeleted is empty
https://github.com/mautic/mautic/pull/6566/files#diff-a22caf80768ad2745ddc23b23520ab94R539

Code continue to delete entities and info about success. But there is no success in that case

[mitresh95]

This will be taken care of for 2.15.1. Sorry for the delay.

[alanhartless]

@kuzmany @npracht this is good be tested again! Sorry we left out part :-)

[npracht]

This PR must be very helpful to prevent the issue mentioned in #6871. @johbuch can you test that please ?

[npracht]

Just tested and it works. Great way to improve UX and side effect issues.

Code updated