New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Psysh REPL for dev usage #6667
Conversation
9508f59
to
197b15f
Compare
Fixed merge conflict. |
I would like to thank you @dongilbert for the work you are doing. |
Updated to fix merge conflict with composer.lock again. @alanhartless |
9661954
to
278cb56
Compare
Rebased on current staging to address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just saved my bacon and worked beautifully.
278cb56
to
35dd67b
Compare
Rebased to staging |
Hi there! We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate. How to do?
Please report results by commenting on your PR to make us administration easier. You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3". |
@dongilbert looks like this needs updating if it is still relevant - can you take a look? |
@RCheesley This has been updated to be compatible with Mautic 3. It was approved long ago for Mautic 2. @alanhartless If you could give your stamp again we could hopefully get this merged soon. |
@dongilbert wonderful, thanks for getting that sorted! |
Codecov Report
@@ Coverage Diff @@
## staging #6667 +/- ##
==========================================
Coverage 29.54% 29.54%
Complexity 33237 33237
==========================================
Files 1936 1936
Lines 115138 115138
==========================================
Hits 34021 34021
Misses 81117 81117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works - as this is a small change that doesn't affect Mautic's functionality directly, I'll go ahead and merge this one. Thanks @dongilbert for the PR and your patience!
cc @mautic/education-team FYI I just created two issues to add this new functionality to the docs: mautic/mautic-community-handbook#19 mautic/developer-documentation#163 |
This pull request has been mentioned on Mautic Community Forums. There might be relevant details there: https://forum.mautic.org/t/mautic-3-1-new-beginnings/15787/1 |
Please be sure you are submitting this against the staging branch.
Description:
This PR adds the Psysh Bundle for Symfony2 to our
require-dev
block incomposer.json
.It allows devs access to the
$container
,$kernel
, and$self
(which is thePsy\Shell
instance itself) from the command line. This lets devs test using their services from the container, as well as improve general debugging capabilities of the app.You can start the repl after applying the PR and running
composer install
.Please test on PHP 5.6 & 7.1
Some usages examples (after starting the repl):
Bonus PHP Docs
Follow instructions here: https://github.com/bobthecow/psysh/wiki/PHP-manual to get docs for built in PHP functions and classes via
doc function_name