Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign email condition all variant check #6765

Merged
merged 2 commits into from Jan 15, 2019

Conversation

Projects
7 participants
@kuzmany
Copy link
Contributor

kuzmany commented Oct 21, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #3898
BC breaks?
Deprecations?

Description:

Report here issue #3898
A/B child email in campaign cannot continue on condition because we check just parent ID.
This PR fixed it.

Steps to reproduce the bug:

  1. Create email with A/B testing variant with 50% weight rate
  2. Create campaign with send email
  3. Add condition open email and add action (points for example)
  4. Add two contacts
  5. Trigger campaign
  6. Open both emails
  7. Just one email will run action after open email decision

Steps to test this PR:

  1. Repeat all steps and see If decision is triggered for both contact as we expect

@kuzmany kuzmany added this to the 2.15.0 milestone Oct 21, 2018

@kuzmany kuzmany self-assigned this Oct 21, 2018

@kuzmany kuzmany added this to Tested once in Testing 2.15.0 Oct 21, 2018

@kuzmany kuzmany moved this from Tested once to To do in Testing 2.15.0 Oct 21, 2018

@kuzmany kuzmany changed the title Campaign email condition all variant Ids check Campaign email condition all variant check Oct 21, 2018

@johbuch
Copy link

johbuch left a comment

tested on mautibox -> works ;)

@johbuch
Copy link

johbuch left a comment

tested on mautibox -> works ;)

@kuzmany kuzmany moved this from To do to Tested once in Testing 2.15.0 Oct 22, 2018

@kuzmany kuzmany moved this from Tested once to To do in Testing 2.15.0 Oct 22, 2018

@kuzmany kuzmany moved this from To do to Tested once in Testing 2.15.0 Oct 22, 2018

@dbhurley dbhurley modified the milestone: 2.15.0 Nov 9, 2018

@AlbanL74fr

This comment has been minimized.

Copy link

AlbanL74fr commented Dec 3, 2018

Tested on Mautibox. Works as expected!

@Woeler Woeler modified the milestones: 2.15.0, 2.15.1 Dec 5, 2018

@Woeler Woeler removed this from Tested once in Testing 2.15.0 Dec 5, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 14, 2019

Mautic 2 automation moved this from Code Review (2 required) to Ready to Test (first time) Jan 15, 2019

@alanhartless alanhartless merged commit 5d98564 into mautic:staging Jan 15, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 15, 2019

@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.