Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate tag list in contact webhooks (#6861) #6899

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Clement134
Copy link
Contributor

@Clement134 Clement134 commented Nov 18, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature? No
Automated tests included? No
Related user documentation PR URL No
Related developer documentation PR URL No
Issues addressed (#s or URLs) #6861
BC breaks? No
Deprecations? No

Description:

At the moment, tag list in the contact webhooks contains only empty objects. This PR, populate tag list with tag's data.

Steps to reproduce the bug:

  1. Create webhook for "Contact Updated Event", "Contact subscription change" and "Contact point change"
  2. Trigger each webhooks for a tagged contact
  3. Check webhook's payload (with empty tag array)

Steps to test this PR:

  1. Create webhook for "Contact Updated Event", "Contact subscription change" and "Contact point change"
  2. Trigger each webhooks for a tagged contact
  3. Check webhook's payload, tags array should be populated with tag's data

List deprecations along with the new alternative:

No deprecations

List backwards compatibility breaks:

No backwards compatibility breaks

@Clement134 Clement134 changed the title Populate tag list in contact updated webhook (#6861) Populate tag list in contact webhooks (#6861) Nov 18, 2018
@kuzmany
Copy link
Member

kuzmany commented Nov 18, 2018

Can you fix the travis check? Looks like error with unit test (Mautic\LeadBundle\Tests\EventListener\WebhookSubscriberTest::testChannelChangeIsPickedUpByWebhook)
https://travis-ci.org/mautic/mautic/jobs/456576272#L671

@Woeler Woeler added this to the 2.15.1 milestone Nov 18, 2018
@Woeler Woeler added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Nov 18, 2018
@npracht npracht modified the milestone: 2.15.1 Dec 3, 2018
@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018
@npracht npracht moved this from Code Review (2 required) to Ready to Test (first time) in Mautic 2 Jan 3, 2019
@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019
@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Jan 30, 2019
@alanhartless alanhartless moved this from Needs Testing to Needs Second Test in 2.15.1 Jan 30, 2019
@npracht npracht removed the ready-to-test PR's that are ready to test label Feb 6, 2019
@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 6, 2019
@alanhartless alanhartless merged commit 35d1152 into mautic:staging Mar 11, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Mar 11, 2019
@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
2.15.1
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants