Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user exist verification #6939

Merged
merged 1 commit into from Mar 4, 2019
Merged

Add user exist verification #6939

merged 1 commit into from Mar 4, 2019

Conversation

Enc3phale
Copy link
Contributor

@Enc3phale Enc3phale commented Nov 29, 2018 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Fix error on form submit, if action Send email to user is selected but selected user is deleted.

Steps to reproduce the bug:

  1. Add two users
  2. Create a form with action Send email to user and add the previous created users, save.
  3. Go to users and delete one of them.
  4. Go to the form and fill it.
  5. error 500
    [2018-11-29 11:11:31] mautic.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalThrowableError: "Call to a member function getEmail() on null" at /app/bundles/EmailBundle/Model/EmailModel.php line 1565

Steps to test this PR:

  1. Load up this PR
  2. Repeat step above
  3. No error and form is submited

@npracht npracht added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Nov 29, 2018
@npracht npracht modified the milestone: 2.15.1 Nov 29, 2018
@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018
@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019
@alanhartless alanhartless added pending-test-confirmation PR's that require one test before they can be merged and removed code-review-needed PR's that require a code review before merging labels Jan 30, 2019
Mautic 2 automation moved this from Code Review (2 required) to Ready to Test (first time) Jan 30, 2019
@alanhartless alanhartless moved this from Needs Testing to Needs Second Test in 2.15.1 Jan 30, 2019
npracht
npracht approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in production environment for several weeks. It works !

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Feb 6, 2019
@alanhartless alanhartless merged commit fec4103 into mautic:staging Mar 4, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Mar 4, 2019
@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
2.15.1
Merged
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enc3phale @alanhartless @npracht