MailHelper: Reset transport as well on reset, solves connection drops #6980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves the way the connection to an external SMTP server is reset. In particular, when using Amazon SES, on regular basis we saw the following error in the logs:
This seems to be related to a connection losses, so to solve those, this PR closes the connection upon resetting the
MailHelper
. It is hard to reproduce this exact bug, but at least if feels very natural to close the connection upon a reset, and in our environment this has solved the issue.Steps to reproduce the bug:
Steps to test this PR: